scier / MetalSplatter

Render Gaussian Splats using Metal on Apple platforms (iOS/iPhone/iPad, macOS, and visionOS)
MIT License
272 stars 35 forks source link

match in_frustum of original cuda implementation #26

Closed Yang-Xijie closed 3 months ago

Yang-Xijie commented 3 months ago

It will be better to change the 0.2 to 0.0 to render all 3D gaussians in front of the camera.

scier commented 3 months ago

There doesn't seem to be a performance penalty from this as far as I can see, and though I couldn't spot any visual differences either, it's better to match the training renderer all things being equal. But first, could you reference the original training renderer code this is matching?

Yang-Xijie commented 3 months ago

I make it clear in the new PR: https://github.com/scier/MetalSplatter/pull/28.