search

scieslak / distance_finder

Get distance and travel time between almost any two places on the globe.
MIT License
0 stars 0 forks source link

Should the calculator status attribute be publically writable? #2

Open ttrmw opened 7 years ago

ttrmw commented 7 years ago

If so, why? If not, why not?

scieslak commented 7 years ago

Well, spotted @ttrmw thank you. I was playing with the status output and had not noticed I left it as attr_accessor. I have changed it to attr_reader. There is no need for it to be publically writable as it only outputs the value received from Google API. However, it may be useful if the requirement for replacing the status with a custom message appear in the future.