search

scifio / scifio-bf-compat

SCIFIO (@scifio/scifio) plug-in allowing use of Bio-Formats readers.
http://scif.io/
BSD 2-Clause "Simplified" License
3 stars 5 forks source link

Rename/Move package: io.scif.common #10

Closed dietzc closed 9 years ago

dietzc commented 9 years ago

Hi @hinerm,

could you rename the package https://github.com/scifio/scifio-bf-compat/tree/master/src/main/java/io/scif/common? Same problem as with imglib2.meta in imagej.commons: OSGi does not allow packages with the same name in different bundles. There is already a package with the same name in: io.scif (https://github.com/scifio/scifio/tree/master/src/main/java/io/scif/common). If its not possible to resolve this conflict, there are ways (hacks ;-)) to do that on OSGi side. However, it would be great if we could resolve it here.

Thanks!

Christian

ctrueden commented 9 years ago

I agree that all classes in scifio-bf-compat should have a common base package name. The io.scif.common.RandomAccessInputStreamWrapper class should be moved.

hinerm commented 9 years ago

Sounds good.. how about io.scif.bf.wrapper ?

Also, since OSGi doesn't allow packages with the same name, how can the deprecated classes still exist in imagej-common?

Just want to make sure it's OK for me to deprecate RandomAccessInputStreamWrapper as well.

Thanks @dietzc !

hinerm commented 9 years ago

https://github.com/scifio/scifio-bf-compat/commit/027d38f455701ec2a7647844ad64a83481b5f68c look good?

ctrueden commented 9 years ago

:+1:

dietzc commented 9 years ago

:+1:

hinerm commented 9 years ago

Released in https://github.com/scifio/scifio-bf-compat/releases/tag/scifio-bf-compat-1.10.1