search

scifio / scifio-ome-xml

SCIFIO plug-in providing support for the OME data model, including readers, writers and translators for OME-XML and OME-TIFF formats.
http://scif.io/
BSD 2-Clause "Simplified" License
2 stars 3 forks source link

IllegalStateException in unit tests #19

Closed dscho closed 10 years ago

dscho commented 10 years ago

While upgrading scifio-ome-xml to work with the latest SCIFIO version, I noticed this stacktrace (even if the unit tests pass):

java.lang.IllegalStateException: Context already injected: io.scif.ome.formats.OMETIFFFormat#service
    at org.scijava.Context.inject(Context.java:276)
    at org.scijava.plugin.DefaultPluginService.createInstance(DefaultPluginService.java:237)
    at org.scijava.plugin.DefaultPluginService.createInstances(DefaultPluginService.java:225)
    at org.scijava.plugin.DefaultPluginService.createInstancesOfType(DefaultPluginService.java:216)
    at io.scif.services.DefaultFormatService.initializeSingletons(DefaultFormatService.java:365)
    at io.scif.services.DefaultFormatService.formats(DefaultFormatService.java:318)
    at io.scif.services.DefaultFormatService.getFormatList(DefaultFormatService.java:288)
    at io.scif.services.DefaultFormatService.getFormat(DefaultFormatService.java:271)
    at io.scif.services.DefaultInitializeService.initializeReader(DefaultInitializeService.java:89)
    at io.scif.services.DefaultInitializeService.initializeReader(DefaultInitializeService.java:82)
    at io.scif.ome.OMEXMLTest.extractOMEXML(OMEXMLTest.java:58)

Potentially worrisome, but it could also be as easy as expecting this exception instead.

hinerm commented 10 years ago

Yep.. this was pretty dumb. Thanks for pointing it out @dscho