scifio / scifio-ome-xml

SCIFIO plug-in providing support for the OME data model, including readers, writers and translators for OME-XML and OME-TIFF formats.
http://scif.io/
BSD 2-Clause "Simplified" License
2 stars 3 forks source link

OMEXML translators need to call super.typedTranslate #4

Closed hinerm closed 10 years ago

hinerm commented 10 years ago

Currently, all OMEXML translators rely on the convention of calling super.typedTranslate to establish baseline metadata population.

however, this is quite error prone. As apparent in the BMPOMETranslator, in which super.typedTranslate was not invoked and is currently broken.

So all the translators should be evaluated for their functionality (in fact, each supported SCIFIO format should be tested - not just those with explicit translators).

Failing translators should be fixed, at a minimum. But perhaps there is a better way...

I think if, at the OMETranslator level, we override translate instead of typedTranslate, we can add a pre-translation hook (which is what's desired) and remove the need for all of these super.typedTranslate calls.