search

scifio / scifio

SCientific Image Format Input & Output: a flexible, extensible framework for image I/O. *EXPERIMENTAL* All API is subject to change, so depend at your own risk! See also @openmicroscopy/bioformats.
http://scif.io/
BSD 2-Clause "Simplified" License
91 stars 37 forks source link

Consolidate ImageMetadata with AbstractCalibratedInterval #73

Open hinerm opened 10 years ago

hinerm commented 10 years ago

ImageMetadata has always had overlap with the Interval API from ImgLib2. With the integration of calibration values to ImageMetadata, this coupling has continued to grow stronger.

Thus it makes sense to formally consolidate these classes by having ImageMetadata extend AbstractCalibratedRealInterval and implement Interval.

This is a similar pattern as ImageJ2's DefaultDataset, so it may be beneficial to create an AbstractCalibratedInterval class in ImgLib to inherit from.

With this refactoring, many of the utility methods (e.g. Calibration in formatTools) can be removed as well as simplifying the ImageMetadata API itself.

hinerm commented 10 years ago

From @ctrueden :

For sure we want to make an AbstractCalibratedInterval, which extends AbstractCalibratedSpace We can model this using AbstractRealInterval & AbstractInterval

hinerm commented 9 years ago

Related to or replaced by #230 ?

hinerm commented 9 years ago

New hierarchy in ImageJ-common: