scify / JedAIToolkit

An open source, high scalability toolkit in Java for Entity Resolution.
http://jedai.scify.org
Apache License 2.0
212 stars 47 forks source link

Remove maven-assembly-plugin Configuration From jeda-core #23

Closed allan-shoup closed 4 years ago

allan-shoup commented 4 years ago

If another project is going to depend on jedai-core, having the transitive dependencies assembled inside jedai-core has the potential to conflict if different versions of those same transitive dependencies are needed for the other project. Since jedai-ui is already assembling transitive dependencies, removing transitive dependencies from jedai-core should not have any effect on the UI.

allan-shoup commented 4 years ago

Pull request to solve this issue: https://github.com/scify/JedAIToolkit/pull/25

xstrtok commented 4 years ago

As the pull request is merged, I'm closing this issue.