search

scify / JedAIToolkit

An open source, high scalability toolkit in Java for Entity Resolution.
http://jedai.scify.org
Apache License 2.0
212 stars 47 forks source link

Change comparison counts type to int #48

Closed eni-veres closed 3 years ago

eni-veres commented 3 years ago

We're using jedai-core in our application and we ran into some issues where the number of executed comparisons in ComparisonIterator was going over the number of total comparisons. We identified that this was happening because executedComparisons and totalComparisons are floats and changing them to ints fixed the problem. In Java, comparing two floats for exact equality is generally discouraged.

eni-veres commented 3 years ago

Added a pull request for this issue https://github.com/scify/JedAIToolkit/pull/49

gpapadis commented 3 years ago

That was really helpful! Thanks!