sciguy1121 / Community-Mod-1

Community Mod 1
GNU Lesser General Public License v3.0
10 stars 16 forks source link

Liquid Concrete #162

Closed EliSussman closed 11 years ago

EliSussman commented 11 years ago

Can anybody please fix the errors in liquid concrete and add the textures? (I already made the texture just didn't impliment them in the classes

EliSussman commented 11 years ago

Anyone???

sciguy1121 commented 11 years ago

I can, I'll try sometime in the next couple days (I'm trying to get a lot of things sorted out)

Techtad commented 11 years ago

I fixed some errors in the classes, but it's still crashing when you place the block and it tried to flow.

Also we can actually organize the mod a little better. I don't think SuitedSlime, Rob, or however needed to clean the code up but he was right that we can easily do it better. For example, it would be cool if we could have the mod working with the development environment set up like in Pahimar's let's mod series(http://www.youtube.com/watch?v=KsNr6ifC2aM), because it would much more comfortable to work in it.

EliSussman commented 11 years ago

Next we have to make the bucket of liquid concrete and get the block flowing without crashing, but I think that is a great idea for our mod (to use that environment) @smigolpol

Techtad commented 11 years ago

OK. I fixed the crash, now the liquid works perfectly, I also fixed the textures for it.

@sciguy1121 @KingCreeperEli But now I have all my code converted to the new environment, so if I make a pull request, will you be able to use it too?

EliSussman commented 11 years ago

Thanks, that is awesome! Also that is a weird situation, im guessing it would work for us but...

Techtad commented 11 years ago

I mean it won't work if anyone doesn't have the new set up yet.

sciguy1121 commented 11 years ago

@smigolpol If you fixed it, go ahead and send the pull request, we can figure things out.

Fermats-Fish commented 11 years ago

What is the new environment?

sciguy1121 commented 11 years ago

@netherrod05 Not sure

ghost commented 11 years ago

It's a configuration for eclipse.

Techtad commented 11 years ago

Like LegioXV said it's a much better configuration for your workspace. I won't make a pull request because you're not using that line of dev environment right now, so my entirely repackaged code may not work for you.

EliSussman commented 11 years ago

Just make the pull request and then we can fix ours to the way you have yours :)

EliSussman commented 11 years ago

Also can once someone fixes the textures and the the spaning problem, can they please make the bucket of liquid concrete because i have already added the texture :)

Techtad commented 11 years ago

I will make the bucket of liquid and then I will send the pull request. There's one problem with the liquid that when it receives a block update it blinks "MISSING TEXTURE" for a second, but otherwise it works correctly.

EliSussman commented 11 years ago

I want to make the liquid condrete to be a solid color like lava, not water...how do we do that... :)

EliSussman commented 11 years ago

Anybody know how to make liquid concrete a solid color? @smigolpol @sciguy1121 @LegioXV @netherrod05

Techtad commented 11 years ago

@KingCreeperEli Can't you just make the texture so that it's not transparent? You need to override some methods in the flowing block and change the speed it flows with. I think you can just copy the code from BlockFlowing and mess around with it.

EliSussman commented 11 years ago

The texture is a solid texture...I just can't figure out how to turn the in game texture into a solid like lava... @smigolpol

ghost commented 11 years ago

The Liquid Concrete texture is semi-transparent.

EliSussman commented 11 years ago

I think I fixed the concrete texture but now the Liquid concrete flowing texture isn't working... :)

Techtad commented 11 years ago

The other thing that I made when I was making the bucket is that it is now a registered Forge liquid. It can now be stored in tanks and transported by waterproof pipes or liquiducts. :) 2013-04-16_14 54 37

EliSussman commented 11 years ago

is anyone elses flowing liquid concrete texture not working?

Techtad commented 11 years ago

@KingCreeperEli Mine is not working now too. There's the old one on the screenshot, I made it before. The animations for robot model and uranium chunk aren't working as well.

Techtad commented 11 years ago

No, I ran the project twice and now the animations work, never mind.

EliSussman commented 11 years ago

Does the liquid cocnrete flowing work?

Techtad commented 11 years ago

No, liquid "cocnrete flowing" doesn't work, and liquid concrete flowing texture doesn't work as well....

EliSussman commented 11 years ago

what do you mean by it doesn't work? I know the texture doesnt work but how does the liquid not work?

Techtad commented 11 years ago

I think I fixed it now. So, never mind. I took the code from BC and it works a lot better.

EliSussman commented 11 years ago

Are you going to make a pull request?

Techtad commented 11 years ago

Yes, I definitely fixed it now. Now it looks more like real world concrete. Do you mind if I also change the animation speed on uranium chunk and robot model? I think it's too fast.

EliSussman commented 11 years ago

Sure, just make sure it looks goog first :)

EliSussman commented 11 years ago

@smigolpol @sciguy1121 There is an error with "theIcon" in both of the 2 classes in the most recent update... :)

Techtad commented 11 years ago

I had no errors. Can you tell of what does the error say so I can tell you what is probably wrong with your instance. Because the code is 100% right.

sciguy1121 commented 11 years ago

@KingCreeperEli I don't get any errors either... What version of Forge are you using?

@smigolpol Also, there was an issue with the silicon wafer not showing up. Does it show up in your game?

EliSussman commented 11 years ago

it is an error with "theIcon"...how do you update forge without redoing the whole 30min process? @sciguy1121 @smigolpol

sciguy1121 commented 11 years ago

@KingCreeperEli Well, which version are you using?

EliSussman commented 11 years ago

um...how do I check?

Techtad commented 11 years ago

I can't tell now because I'm writing this from a mobile phone. It's almost midnight in my time zone(CET). Goodnight.

EliSussman commented 11 years ago

oh...sorry, @sciguy1121 can you tell me?

sciguy1121 commented 11 years ago

@KingCreeperEli Well, quick way to check: did you download it from "Main Forge Download March 26th?"

EliSussman commented 11 years ago

I used the same one pahimar did in his tutorial @sciguy1121

EliSussman commented 11 years ago

How do I update without redoing the whole 30 min process

sciguy1121 commented 11 years ago

@KingCreeperEli Well, you can't

EliSussman commented 11 years ago

oh...well ill be gone the next hour :P @sciguy1121

EliSussman commented 11 years ago

@sciguy1121 @smigolpol @LegioXV I updated forge to the latest version in the main download..now I have errors wherever there is metadata involved (getBlockTextureFromSideAndMetadata) and wherever items are involved in the texture area...

DeathSeeker512 commented 11 years ago

@KingCreeperEli so is this issue done?

Fermats-Fish commented 11 years ago

@KingCreeperEli when you updated did add the minecraft 1.2 folders or 1.1?

Techtad commented 11 years ago

@netherrod05 Do you realize that you're replying to a comment on the issue from over a month ago? It's outdated now, no help needed. @DeathSeeker512 Yes, it's fixed now, I suppose, since we don't use the method getBlockTextureFromSideAndMetadata, because it doesn't exist any more.

DeathSeeker512 commented 11 years ago

@KingCreeperEli @sciguy1121 can you close this...