search

sciguy1121 / Community-Mod-1

Community Mod 1
GNU Lesser General Public License v3.0
10 stars 16 forks source link

Concrete Hardening #169

Open sciguy1121 opened 11 years ago

sciguy1121 commented 11 years ago

Sometimes, while hardening, the concrete will cut off other concrete blocks from the source, so they disappear.

EliSussman commented 11 years ago

Does concrete already harden in our mod or do we have to add it?

EliSussman commented 11 years ago

@sciguy1121

sciguy1121 commented 11 years ago

I just added hardening.

EliSussman commented 11 years ago

after how long does it harden @sciguy1121

EliSussman commented 11 years ago

It isn't hardening for me, how long does it take? @sciguy1121

Techtad commented 11 years ago

I added hardening in my pull request too, but I serialized it because when you broke the blocks it hardened into they were becoming liquid again.

EliSussman commented 11 years ago

well once you figure out how to make concrete harden right just tell me so I can test how long it takes :)

Techtad commented 11 years ago

For now I think it's random how long it takes, when I was writing it I wanted it to be at least 3 seconds...

EliSussman commented 11 years ago

@smigolpol I dont think it hardens for me, i left it there for 3 mins and nothing happened... :)

Techtad commented 11 years ago

@KingCreeperEli Make sure you have the latest version of this repository downloaded.

EliSussman commented 11 years ago

@smigolpol I have the latest one and its not hardening, does it harden for you?

Techtad commented 11 years ago

No, It actually doesn't. I made it tick randomly and now I think 400 random ticks is just too much.

EliSussman commented 11 years ago

make it between 10-100 or something like that :)

Techtad commented 11 years ago

I did make it between 10-100 and you can see it harden now, but it's still very slow sometimes. I think there's too much randomness.

EliSussman commented 11 years ago

Just make the pull request when you think you have a good number and ill test it too :) @smigolpol

Techtad commented 11 years ago

I think I found out why it doesn't harden. It does actually harden, but for only less than 1 tick so you can't actually see it because it automaticly receives an update which forces it to turn into liquid for again. I have no idea why it happens...

EliSussman commented 11 years ago

@smigolpol @sciguy1121 Well I hope we can get this figured out and then i will test it :)

Techtad commented 11 years ago

I don't have time to fix it today, so I hope it gets fixed as soon as possible.

EliSussman commented 11 years ago

Thats fine, whenever you have time :) @smigolpol

sciguy1121 commented 11 years ago

@smigolpol I thought I had fixed that. I'll take a look at it when I can.

EliSussman commented 11 years ago

If their is anything I could do to help...

EliSussman commented 11 years ago

Still no fix?

Techtad commented 11 years ago

It seems to be working now, but not all the time. the bug with turning back to liquid is fixed, so that's good.

EliSussman commented 11 years ago

Can you make a pull request then? :)

Techtad commented 11 years ago

I did not fix it, it just works for me without doing anything.

EliSussman commented 11 years ago

oh...

EliSussman commented 11 years ago

Now that we have a new forge update...is there a fix anyone can figure out?

DeathSeeker512 commented 11 years ago

we could have it delete the liquid block in the location when it is placed

Fermats-Fish commented 11 years ago

I tried using it and I found that the concrete only hardens when it gets updated by another block. And even then it has a chance of not hardening.