search

sciguy1121 / Community-Mod-1

Community Mod 1
GNU Lesser General Public License v3.0
10 stars 16 forks source link

Some clean up, mcmod.info file and minor changes. #187

Closed Techtad closed 11 years ago

Techtad commented 11 years ago

I've cleaned up some really messy code. I've alsoe noticed that we had 2 or 3 completely unused classes, that we will never use. There was also some outdated methods that weren't deleted. I have added @SuppressWarning annotations where the warnings weren't important.

I've added an mcmod.info file. I've added a logo image to the request, I think it would be nice to have it.

EliSussman commented 11 years ago

How big should the logo be? I might start on it now :) @smigolpol

Techtad commented 11 years ago

@KingCreeperEli Well, I checked on BuildCraft logo and I think it should be 256 x 43 pixels.

Techtad commented 11 years ago

@KingCreeperEli But I think it can be a little bigger than that, because BC logo doesn't fill all the space available.

Techtad commented 11 years ago

I think the logo can be at max 300 pixels wide and about 72 pixels tall. I'm not sure.

sciguy1121 commented 11 years ago

It won't let me merge, could you copy in your changes again?

Techtad commented 11 years ago

It won't let you merge because you merged the other pull request before and it changes some of the files this one does. But, no problem, I'll redo all the changes. :)