search

scihant / CTPanoramaView

A library that displays spherical or cylindrical panoramas with touch or motion based controls.
MIT License
1.04k stars 89 forks source link

Why does deployment target is iOS 12 now? #56

Closed Sega-Zero closed 3 years ago

Sega-Zero commented 3 years ago

The readme file declares iOS 8.0+, but podspec requires iOS12. Where is the mistake?

scihant commented 3 years ago

Yes, it seems like I forgot to update it. The podspec is correct. iOS 8.0 is way too old.

Sega-Zero commented 3 years ago

Yep, but there is nothing in the code that should drop iOS 8 support? I use your library on iOS 9+ project and everything is working fine ¯_(ツ)_/¯

scihant commented 3 years ago

That might be true :) iOS 12 isn't really necessary but if I remember correctly, Xcode 12 doesn't really support iOS 8.0. Don't know about 9.0 though. I could reduce it to the minimum iOS version latest XCode supports (which certainly is lower than 12)

Sega-Zero commented 3 years ago

Supporting iOS8 project in XCode12 without any troubles :)

scihant commented 3 years ago

I've just checked. It doesn't list 8.0 as an option out of the box.

But you're right about the rest. I don't really remember why I bumped the version to 12. I even have some availability checks for iOS 11 in code, so it must be a mistake :)

I'll fix this when I'm able.

Sega-Zero commented 3 years ago

Thanks!

scihant commented 3 years ago

It's 10.0 now.