search

scijava / scijava-common

A plugin framework and application container with built-in extensibility mechanism :electric_plug:
BSD 2-Clause "Simplified" License
85 stars 53 forks source link

Only convert to array types when it is possible #449

Closed gselzer closed 1 year ago

gselzer commented 1 year ago

This closes #448.

Instead of reporting that DefaultConverter can convert anything to an array, we only report that we can convert things that ArrayUtils.toCollection can actually convert into a Collection.

One other concern is whether the case logic might lead to action-at-a-distance errors.

gselzer commented 1 year ago

@ctrueden how do these changes fare with backwards compatibility?

ctrueden commented 1 year ago

how do these changes fare with backwards compatibility?

I don't foresee any problems! The tests all passed, so it must be bug-free! :trophy: