scijava / scijava-common

A plugin framework and application container with built-in extensibility mechanism :electric_plug:
BSD 2-Clause "Simplified" License
87 stars 52 forks source link

Add FileWidget.FILE_AND_DIRECTORY_STYLE #480

Closed tischi closed 2 months ago

NicoKiaru commented 3 months ago

Quick note to mention that the documentation in imagej.net needs to be updated once the PR is merged:

https://imagej.net/scripting/parameters

NicoKiaru commented 3 months ago

Also, instead of "both", maybe something like "file_or_directory", since "both" isn't very clear out of context. Last, how does this behave with a file array parameter ?

tischi commented 3 months ago

I am using "both" because that's what is already used for the FileListWidget.

NicoKiaru commented 3 months ago

Ah great! Then the FileArray widget is already working. Good to know!

tischi commented 3 months ago

Thanks @imagejan, these TODO were not added by me, but what you did LGTM.

Do I need to accept/commit your changes or can you do it?

ctrueden commented 2 months ago

Thanks, all!