search

scijava / scijava-scripts

Shell scripts for scientific projects written in Java
The Unlicense
15 stars 16 forks source link

Developer profiles #7

Closed hinerm closed 10 years ago

hinerm commented 10 years ago

@dscho @ctrueden this PR updates bump-pom-scijava.sh to work with the developer-profiles branch of pom-scijava.

I just wanted @dscho especially to sign off on these changes, that I'm updating the profile properties correctly.

Thanks!

dscho commented 10 years ago

I fear that we cannot really ask maven-helper to give us the current -SNAPSHOT version after a release was deployed and pom-scijava is to be updated.

Imagine, for example, if someone deploys a new release of, say, imglib2-ij and then immediately bumps pom-scijava, without giving Jenkins a chance to deploy the new -SNAPSHOT version first. That's the situation I am most concerned about...

ctrueden commented 10 years ago

Note that I, as the inconsiderate person that I am, merged developer-profiles into pom-scijava master but without the start/end anchor comments. I didn't like them.

I would like to find a different approach to fixing the bump-pom-scijava script that does not need them.

hinerm commented 10 years ago

@ctrueden yep I am on board.

dscho commented 10 years ago

I took the branch, renamed it to developer-profiles, fixed a few things here and there, and then merged it in afcae7fc9e (and fixed my premature merge up in 57c353d73b).

ctrueden commented 10 years ago

Thanks!