search

scijava / scijava-search

Search framework for SciJava applications :mag:
BSD 2-Clause "Simplified" License
2 stars 2 forks source link

Add JSON-based Image.sc forum search #21

Closed imagejan closed 3 years ago

imagejan commented 3 years ago

To parse the JSON query result, we use gson, which is managed in pom-scijava already. Also deactivate the old (currently non-functional) forum search.

The second commit is a trial to add the forum avatars as icons in the search panel, but unfortunately it makes the search very slow. Maybe others have a suggestion how to speed it up by caching or deferred loading, maybe also using DownloadService?

If there's no good way to have lazy loading of avatars, I suggest merging only the first commit of this pull request.

Fixes #15, see also #20.

image

ctrueden commented 3 years ago

Thanks for updating this, @imagejan!

Would you be OK with simply removing the old ImageForumSearcher implementation? I see no point in leaving it lying around. This component is still at 0.x and nobody should be depending on it, especially specific plugin implementations.

imagejan commented 3 years ago

@ctrueden thanks, I removed ImageForumSearcher in https://github.com/scijava/scijava-search/pull/21/commits/af0dd6869b14ac47546fd5f247c7260accf82c78. Let me know if that's ok or I should squash this with https://github.com/scijava/scijava-search/pull/21/commits/73376fd61c415250cc6a3efd33ed286544d1fe7a.