search

scijava / scijava-search

Search framework for SciJava applications :mag:
BSD 2-Clause "Simplified" License
2 stars 2 forks source link

Port imagej legacy search actions #24

Closed gselzer closed 1 year ago

gselzer commented 2 years ago

This PR does part of the work of partitioning ImageJ Legacy's SourceSearchActionFactory, splitting off the section of that SearchActionFactory that deals with Modules.

To prevent code duplication while preserving SRP, we create an abstract class SourceSearchActionFactory and rename the current SourceSearchActionFactory for Classes into ClassSourceSearchActionFactory. Then ModuleSourceSearchActionFactory was created to contain the migrated functionality.

See scijava/script-editor#63 for the other chunk of migrated functionality.

gselzer commented 2 years ago

@ctrueden I think I addressed all of your concerns, thanks again for taking a look. Please let me know what you think