Allow only one search action per name

scijava / scijava-search

Search framework for SciJava applications :mag:

BSD 2-Clause "Simplified" License

2 stars 2 forks source link

Closed gselzer closed 1 year ago

gselzer commented 1 year ago

This can remove confusion with "equivalent" search actions. With "equivalent" search actions, we mean actions of the same name.

The actions that is kept is the action coming from the highest priority SearchActionFactory.

hinerm commented 1 year ago

@gselzer I was testing this downstream in napari-imagej and wanted to make sure I understand the state of things:

There is now just one Help/Source button (yay!)
The links in these are coming from ImageJ-Legacy
The fact that these are broken is a fix for IJ-Legacy (is there already an issue? I didn't see one)

Is that right?

gselzer commented 1 year ago

The links in these are coming from ImageJ-Legacy

If it is a LegacyCommand in the search results, then yes!

The fact that these are broken is a fix for IJ-Legacy (is there already an issue? I didn't see one)

Yes, it is. I'll write an issue, and then I'll write a PR!