search

scijava / scijava-search

Search framework for SciJava applications :mag:
BSD 2-Clause "Simplified" License
2 stars 2 forks source link

Disallowlist for visible commands? #31

Open tferr opened 1 year ago

tferr commented 1 year ago

This pertains to https://github.com/morphonets/SNT/issues/174:

In order to be discovered by napari-imagej, SNT commands need to be visible, but doing so makes them appear as SwingSearchBar search results. However, running these commands from the SearchBar won't make much sense since the inputs won't be properly defined, since they are set from SNT itself.

Is there a way around this? Perhaps flagging them somehow as 'non-ImageJ-registered' commands?

ctrueden commented 1 year ago

Sorry @tferr @gselzer, I don't understand what the problem is.

What does it mean for a command to be "visible" to napari-imagej? Appear in napari-imagej's search bar? The napari-imagej search bar is the SciJava search bar, the same stuff appears in both. Why would you want these SNT commands to appear in the napari-imagej search bar, but not appear in the Fiji search bar? Can you give me an example of which commands we're talking about, and how a workflow using them should work?

tferr commented 1 year ago

I probably did not explain the problem well. The original problem is described here: https://github.com/imagej/napari-imagej/issues/262 (sorry for not linking to it), and it relates to the commands not being accessible from napari-imagej.

ctrueden commented 1 year ago

Thanks @tferr for the additional explanation. I'll look this over more carefully tomorrow morning (EU time), and reply back then with my opinion on how to proceed.