Closed karlduderstadt closed 10 months ago
This pull request has been mentioned on Image.sc Forum. There might be relevant details there:
https://forum.image.sc/t/python-syntax-highlighting-stopped-working-in-fiji-script-editor/83615/3
@ctrueden , @karlduderstadt : This is causing major disruptions because without it jython autocompletions don't work. I know this is planned for the next release, but unless that is imminent , I would merge this now. I have bandwidth to do it. I could: 1) Merge and push the current SNAPSHOT to the java8 update site, or 2) Merge, cut a new release, and push that to the java8 update site
Let me know what you prefer/would be best..
EDIT: Oh, I just read with more detail the discussion in the forum post. I see now that more refactoring is planned, sorry for missing it. Either way, let me know how can I help, and/or if my proposals above can be used as a stop-gap
Thanks Tiago, I wouldn't mind either, the disruption has gone on for so long already.
On Fri, 19 Jan 2024, 13:29 Tiago Ferreira, @.***> wrote:
@ctrueden https://github.com/ctrueden , @karlduderstadt https://github.com/karlduderstadt : This is causing major disruptions because without it jython autocompletions don't work. I know this is planned for the next release, but unless that is imminent , I would merge this now. I have bandwidth to do it. I could:
- Merge and push the current SNAPSHOT to the java8 update site, or
- Merge, cut a new release, and push that to the java8 update site
Let me know what you prefer/would be best
— Reply to this email directly, view it on GitHub https://github.com/scijava/script-editor-jython/pull/17#issuecomment-1900428254, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMKGQUKL2YAWWUQH5KTHDYPJYJXAVCNFSM55ARCAD2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJQGA2DEOBSGU2A . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Sounds great to me! I would have done it myself, but I don't have access to those update sites. I am really sorry for all the trouble. Would be great to have the fix now. The refactoring can happen later.
I released script-editor-jython v1.0.1 including this change, and updated the version in pom-scijava (scijava/pom-scijava@1fd6bd2ca3a3d6a544a40b0307e074ef70969456). I was going upload it as a hot-fix to the core Java-8 update site to end the suffering, but in a quick test just now, this change does not actually fix the Jython syntax highlighting in the Script Editor for me. What am I forgetting?
Thanks @ctrueden! For it to work the other PR in scripting-jython https://github.com/scijava/scripting-jython/pull/12 also needs to be merged and released that actually adds the highlighter. This only renames the scripting language for the autocompletion. I included both in my post on the forum https://forum.image.sc/t/python-syntax-highlighting-stopped-working-in-fiji-script-editor/83615/3
Thanks for the reminder @karlduderstadt. I moved your JythonScriptSyntaxHighlighter
class to script-editor-jython and released another new version, v1.1.0, and uploaded it to the core update site.
Thanks! That makes a lot more sense. I should have done that. Glad this is fixed.
This change will prevent confusion with the new Python (PyImageJ) language.
This change is required for autocompletion to work with the renamed language in scripting-jython https://github.com/scijava/scripting-jython/commit/07dc8b0a5fe840c0f70669be564cfc1f926c1f12