search

scijava / script-editor-jython

Jython plugin for the SciJava Script Editor
BSD 2-Clause "Simplified" License
2 stars 2 forks source link

Improve visibility of auto-completion shortcut #8

Closed tferr closed 2 years ago

tferr commented 2 years ago

As mentioned in the forum, it is not obvious that auto-completion requires Ctrl+Space. Also, IJM auto-completion does not require it. We should make things more obvious and consistent, by making the shortcut more obvious in the GUI, and by making it optional.

@haesleinhuepf, @ctrueden, @imagejan: Do you know how the IJM auto-completion bypasses Ctrl+Space?

imagesc-bot commented 2 years ago

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/jython-auto-completion-of-fiji-methods-in-eclipse-ide/63103/10

imagesc-bot commented 2 years ago

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/cant-release-project-script-editor/63240/30

haesleinhuepf commented 2 years ago

@haesleinhuepf, @ctrueden, @imagejan: Do you know how the IJM auto-completion bypasses Ctrl+Space?

I implemented that to mimic IntelliJ-behaviour: https://github.com/imagej/imagej-legacy/blob/master/src/main/java/net/imagej/legacy/plugin/MacroLanguageSupportPlugin.java#L165

tferr commented 2 years ago

I did not know that! Neat! To me, Ctrl+Space is muscle memory because that's what I'm used to in Eclipse. How do you suggest handling this? Shall we implement the same on the jython side (thus disabling the need for the shortcut combo), or shall it become a formal option somewhere in the GUI? If the latter, I would really need some loose pointers on where to implement that.

pinging @acardona for opinion

haesleinhuepf commented 2 years ago

I presume the Eclipse-based developers will have this opinion and IntelliJ-based developers will have that opinion.

I implemented the auto-completion in a way that it jumps into the face of macro-programmers intentionally. I assume if it wasn't like this, the majority of users would have never discovered that auto-completion exists.

Having an option to switch it to press-CTRL+space-to-auto-complete makes sense though. It could live right next to the checkbox that turns auto-completion completely off:

https://github.com/scijava/script-editor/blob/546062a25625da0cb34dd51af9b98105f7f82ace/src/main/java/org/scijava/ui/swing/script/TextEditor.java#L1463

acardona commented 2 years ago

Control+space works, can't add these new features: instead, I spent all my time trying, and failing, to release other features. The mvn build system is broken to the bone is some fundamentally horrible way, and now it stole the time I had to actually add value.

If you think what I am saying is hyperbole, see the last events on the saga: now even Fiji.app downloaded from fiji.sc doesn't launch. And when it does after removing the offending jar file, then the updater freezes. I mean one can't make this stuff up. https://forum.image.sc/t/cant-release-project-script-editor/63240/40?u=albertcardona

imagejan commented 2 years ago

@haesleinhuepf wrote:

Having an option to switch it to press-CTRL+space-to-auto-complete makes sense though.

Absolutely. I suggested this a while ago here: https://github.com/imagej/imagej-legacy/issues/254

tferr commented 2 years ago

Closing this, as it is addressed by PR#56