search

scijava / script-editor

Script Editor and Interpreter for SciJava script languages
http://imagej.net/Script_Editor
BSD 2-Clause "Simplified" License
12 stars 12 forks source link

Adjust fonts of the screen and error window when adjusting the editor's font #26

Closed acardona closed 5 years ago

acardona commented 5 years ago

Until this commit, the font of the screen (the lower part) was not adjusted when adjusting the font of the editor pane (the upper part). With this commit, it does.

acardona commented 5 years ago

By the way, I wrote a good part of the Script Editor code. I find it strange that it is not credited to me in the scijava repository: like it was copy pasted and committed by someone else at some point, when split from the main Fiji repository.

Also it would be nice to have committer rights to fix my own broken code.

imagejan commented 5 years ago

@acardona looking back in the commit history of this repository, there's a substantial number of commits by yourself in the 2010/2011 range. Could you point to some place where you're not credited appropriately, so that it can be fixed?

Also it would be nice to have committer rights to fix my own broken code.

As far as I understand the SciJava Governance, push permission to the repository should be granted to all who actively maintain the project and take over responsibility for fixing issues etc. If you're willing to take over some of the roles {Developer, Debugger, Maintainer}, I'm sure you will be happily granted committer rights.

imagejan commented 5 years ago

I checked out and tested these changes on Mac OSX. Everything works as advertised and is good to merge, in my opinion. Thanks for the fixes, @acardona.

acardona commented 5 years ago

Thanks Jan, glad that I was wrong then. This page misled me, as it doesn't list neither the Google Summer of code student that wrote a lot of the Script Editor code, nor myself: https://github.com/scijava/script-editor/graphs/contributors

On Nov 3, 2018, at 3:39 PM, Jan Eglinger notifications@github.com wrote:

@acardona looking back in the commit history of this repository, there's a substantial number of commits by yourself in the 2010/2011 range. Could you point to some place where you're not credited appropriately, so that it can be fixed?

Also it would be nice to have committer rights to fix my own broken code.

As far as I understand the SciJava Governance, push permission to the repository should be granted to all who actively maintain the project and take over responsibility for fixing issues etc. If you're willing to take over some of the roles {Developer, Debugger, Maintainer}, I'm sure you will be happily granted committer rights.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

acardona commented 5 years ago

On committer rights: if you could grant them, thank you.

On Nov 3, 2018, at 3:39 PM, Jan Eglinger notifications@github.com wrote:

@acardona looking back in the commit history of this repository, there's a substantial number of commits by yourself in the 2010/2011 range. Could you point to some place where you're not credited appropriately, so that it can be fixed?

Also it would be nice to have committer rights to fix my own broken code.

As far as I understand the SciJava Governance, push permission to the repository should be granted to all who actively maintain the project and take over responsibility for fixing issues etc. If you're willing to take over some of the roles {Developer, Debugger, Maintainer}, I'm sure you will be happily granted committer rights.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

acardona commented 5 years ago

If tests pass, and @imagejan tested the changes and it works for him too, please can this PR be merged.

ctrueden commented 5 years ago

Thanks for the patch, @acardona! Thanks for testing, @imagejan!

I added 92128e4f6dc85aed2736589566f9eb3015dfb0dc which bumps the version to 0.4.0-SNAPSHOT, since there is new public API.

@acardona @imagejan I added you two as collaborators to this repository. (No one had been added yet, since it was relatively new.) Please let me know which SciJava team roles you can commit to regarding this project, and I'll update the info in the POM accordingly.

ctrueden commented 5 years ago

This page misled me, as it doesn't list neither the Google Summer of code student that wrote a lot of the Script Editor code, nor myself: https://github.com/scijava/script-editor/graphs/contributors

@acardona I think that is due to the email addresses used. If you do git shortlog -nse you'll see that your gmail address has only 1 commit, whereas the rest were done under different emails. I bet if you add your other email addresses (particularly the ethz.ch address) on GitHub, it will start counting your statistics better.

By the way: regarding giving credit where credit is due: I have been working for a long time on autogenerating wiki sidebars from the pom.xml metadata. You can see the result for the Script Editor here: https://imagej.net/Template:ComponentStats:org.scijava:script-editor. There are still a couple of rough edges:

acardona commented 5 years ago

Hi @ctrueden , I could take the "Developer" role for this project.

On the ethz.ch email: I can no longer access it, so I can't verify it. Such is the nature of academic emails. Hence I use my gmail as much as I can for git repositories.

On 92128e4, is the POM update done automatically with a script, or do you manually edit the XML files? Is the manual on POMs current?

ctrueden commented 5 years ago

I could take the "Developer" role for this project.

Sounds good. Apologies for the long delay. Done in 59b9054f5f38ec2acded753c6eed0d55a3dbded4.

Keep in mind that means that if someone on the forum requests a new Script Editor feature, you are broadcasting that you will consider implementing it as your time allows. But since you are not taking the support or reviewer roles, you are broadcasting that you typically won't respond to Script Editor questions on the forum, nor to pull requests submitted to the repository. Was that your intent?

On 92128e4, is the POM update done automatically with a script, or do you manually edit the XML files?

I always edit POMs manually, or via sed or similar shell scripting techniques. There is no automated tooling because the POMs are the source of the metadata. All the tooling is downstream from the POMs, consuming them to generate more things.

Is the manual on POMs current?

The closest thing we have to a manual is the pom-scijava-base README. The information there is accurate and current, but probably not really an introductory guide.

acardona commented 5 years ago

Thanks!

Missatge de Curtis Rueden notifications@github.com del dia dj., 14 de març 2019 a les 14:37:

I could take the "Developer" role for this project.

Sounds good. Apologies for the long delay. Done in 59b9054 https://github.com/scijava/script-editor/commit/59b9054f5f38ec2acded753c6eed0d55a3dbded4 .

Keep in mind that means that if someone on the forum requests a new Script Editor feature, you are broadcasting that you will consider implementing it as your time allows. But since you are not taking the support or reviewer roles, you are broadcasting that you typically won't respond to Script Editor questions on the forum, nor to pull requests submitted to the repository. Was that your intent?

On 92128e4 https://github.com/scijava/script-editor/commit/92128e4f6dc85aed2736589566f9eb3015dfb0dc, is the POM update done automatically with a script, or do you manually edit the XML files?

I always edit POMs manually, or via sed or similar shell scripting techniques. There is no automated tooling because the POMs are the source of the metadata. All the tooling is downstream from the POMs, consuming them to generate more things.

Is the manual on POMs current?

The closest thing we have to a manual is the pom-scijava-base README https://github.com/scijava/pom-scijava-base/blob/master/README.md. The information there is accurate and current, but probably not really an introductory guide.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/scijava/script-editor/pull/26#issuecomment-472890658, or mute the thread https://github.com/notifications/unsubscribe-auth/AADFGvg0PiKvMKA41ClbEI3R54-tqLpzks5vWl7FgaJpZM4YMk0Q .