search

scijava / script-editor

Script Editor and Interpreter for SciJava script languages
http://imagej.net/Script_Editor
BSD 2-Clause "Simplified" License
12 stars 12 forks source link

Filter listed files #35

Closed acardona closed 5 years ago

acardona commented 5 years ago

Implements #33, adding a text box to filter listed files in the FileSystemTree by matching text or by regular expression when the first character is a '/'.

acardona commented 5 years ago

Hi @ctrueden, can I merge this, given the new status as 'dev'?

Note this PR includes also the commits in PR #34

ctrueden commented 5 years ago

@acardona Yes, please merge whatever you like, if you are confident in the changes. You can file a PR to request review in cases where you want it (knowing it may take longer for people to go over the code). Or in cases where you don't feel a review is warranted, just push non-fast-forward merge commits directly without using a PR.

acardona commented 5 years ago

Thanks @ctrueden but do I have permissions? Github isn't showing the merge button.

On May 10, 2019, at 12:03 PM, Curtis Rueden notifications@github.com wrote:

@acardona Yes, please merge whatever you like, if you are confident in the changes. You can file a PR to request review in cases where you want it (knowing it may take longer for people to go over the code). Or in cases where you don't feel a review is warranted, just push non-fast-forward merge commits directly without using a PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

acardona commented 5 years ago

Hi @ctrueden , I can't push to scijava master branch, and I can't see a merge button here. So how do I merge?

ctrueden commented 5 years ago

Sorry for the delay in reply, @acardona. You have to accept the invitation by visiting this link: https://github.com/scijava/script-editor/invitations. Then you should have push access as well as the ability to merge PRs.