search

scijava / scripting-jython

JSR-223-compliant Jython scripting plugin
http://imagej.net/Jython_Scripting
BSD 2-Clause "Simplified" License
6 stars 5 forks source link

Consider using the JSR-223 ScriptEngine shipped with Jython #4

Closed ctrueden closed 7 years ago

ctrueden commented 9 years ago

Right now, this component provides its own JSR-223 ScriptEngine, which has pros and cons compared to the one shipped with Jython. IIRC, I tried Jython's built-in ScriptEngine but it had blocking issues. However, in conjunction with #3 (i.e., once we have updated to Jython 2.7.0), we can try again. It would be simpler to avoid our own implementation, which behaves differently from the official implementation. (For example: I am guessing 2a4d4dcc9f58c04ac31150eb8bb941f13deb9dd6 would not have been necessary were we using the built-in ScriptEngine.)

hinerm commented 9 years ago

This issue was originally blocked due to a bug in the jython script engine.

It looks like this has been resolved and we can migrate as soon as we update to Java 7.

hinerm commented 9 years ago

see https://github.com/scijava/scripting-jython/tree/jsr-223-engine

hinerm commented 8 years ago

@ctrueden fyi using the JSR-223 engine had no effect on http://fiji.sc/bugzilla/show_bug.cgi?id=1203. That bug required a different approach

ctrueden commented 7 years ago

Done in c8e8fdef345779c588fb1eaeb02d91f8e3feaedc.