scijava / scripting-kotlin

[EXPERIMENTAL] JSR-223-compliant Kotlin scripting plugin
http://imagej.net/Kotlin_Scripting
Other
10 stars 2 forks source link

POM: Update Kotlin to 1.7.20 #9

Closed skalarproduktraum closed 1 year ago

skalarproduktraum commented 2 years ago

This PR bumps Kotlin to 1.7.20.

ctrueden commented 2 years ago

Thanks @skalarproduktraum. To bump Kotlin, we need to change it in pom-scijava-base (as you did with scijava/pom-scijava-base#32), propagating into pom-scijava, propagating here. I believe I tried this recently and there were problems; I will report back on scijava/pom-scijava-base#32 with details.

ctrueden commented 2 years ago

OK, so after doing some pom-scijava melting-pots, I think the problem just has to do with how version properties are propagated by the melt scripts, resulting in skew between kotlin components. The actual update appears to be fine. I'm going to go ahead with it on the pom-scijava-base side.

ctrueden commented 1 year ago

Based on my tests, I believe this PR is unnecessary. The existing scripting-kotlin appears to work with the updated kotlin 1.7.20 at runtime without needing to be tweaked or even recompiled. Thanks @skalarproduktraum for spurring me to work on this!