scijs / get-pixels

Reads an image into an ndarray
MIT License
543 stars 108 forks source link

Needed dependency upgrades #35

Closed benwiley4000 closed 6 years ago

benwiley4000 commented 7 years ago

Closes #34.

The goal was to upgrade jpeg-js to the latest released version, which solves the issue of ugilifyjs failing on this library. It also brings some algorithm improvements. jpeg-js has now been upgraded to ^0.3.2.

However I had to install new versions of a couple of dev dependencies along the way:

Tests

Server tests The tests did not all pass, but the test results before and after the jpeg-js upgrade are the same: 2686 passing, 18 failing.

Browser tests The tests did not all pass, but the test results before and after the jpeg-js upgrade are the same: 2667 passing, 37 failing. Of course I wasn't able to compare to the test runs with beefy version 1, which couldn't build, so it's always possible that could be related.