search

scijs / ndarray-blas-level2

BLAS Level 2 operations for ndarrays
MIT License
9 stars 2 forks source link

Reorganized for new style. #3

Closed tab58 closed 8 years ago

tab58 commented 8 years ago

Placed functions into separate files. Changed style and linter to semistandard.js. Functions in index.js couldn't be called like 'blas2.gemv' because of a nesting problem, which is fixed so mocha tests pass.

PTAL @rreusser and tell me if I'm too early on this change.

rreusser commented 8 years ago

Awesome! Thanks! Been a hectic week but I'll review ASAP.

tab58 commented 8 years ago

Sounds good @rreusser. I actually already merged it, which may not have been the right thing but I guess we can always revert though. I had been working on GBMV, and I wanted to get those changes in.

If you want me to wait for a LGTM or a "ship it", I will from now on. Let me know.

On Thu, Mar 24, 2016 at 10:05 PM, Ricky Reusser notifications@github.com wrote:

Awesome! Thanks! Been a hectic week but I'll review ASAP.

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub https://github.com/scijs/ndarray-blas-level2/pull/3#issuecomment-201136894