scijs / ndarray-blas-level2

BLAS Level 2 operations for ndarrays
MIT License
9 stars 2 forks source link

Added GBMV with unit test, fixed GEMV function #4

Closed tab58 closed 8 years ago

tab58 commented 8 years ago

PTAL @rreusser.

rreusser commented 8 years ago

Awesome! Closely related things that may be useful for testing, comparison, reference, etc:

The banded stuff is pretty straightforward, but gets to more of those details where strided vs. getter/setter vs. vanilla array vs. ndarray stuff starts to surface.

But all of that aside, specific thoughts:

:+1:

rreusser commented 8 years ago

Also, need to investigate exactly how BLAS handles compressed formats like diagonal matrices. Does BLAS deal strictly in dense full-storage formats and things like compressed banded storage are a completely separate problem?

tab58 commented 8 years ago

AFAIK, BLAS only handles full matrices, with the exception of triangular packed matrices. There may be support in other libraries like LAPACK to take advantage of compressed banded matrices, but I think that's outside the scope of this library.

Are there any other things that I need to do on this before this can get merged in?