search

scijs / ndarray-householder-qr

Householder triangularization for QR Factorization of ndarrays
10 stars 1 forks source link

Fix cwise browserify transform #3

Closed rreusser closed 9 years ago

rreusser commented 9 years ago

@mikolalysenko — I think a bunch of my modules will fail on browserify because I may have left the cwise transform in without a cwise dependency. Can you confirm:

All modules that directly or indirectly include cwise as a dependency should have the browserify transform in package.json and a cwise dependency?

I also need to check whether my dependencies + sub-dependencies are pulling in duplicate dependencies when browserified.

mikolalysenko commented 9 years ago

Yes, if you are using cwise you need to add it as a dependency. Regarding duplicate dependencies, it is no big deal. Just run npm dedupe before you bundle it:

https://docs.npmjs.com/cli/dedupe

It will get even better in npm 3, where dependency deduplication will become more streamlined.

rreusser commented 9 years ago

Perfect, thanks!

rreusser commented 9 years ago

Added proper dependency. Now works with browserify.