search

scijs / scijs-ndarray-for-matlab-users

Common scijs/ndarray operations for people familar with MATLAB (or at least not familiar with scijs)
18 stars 1 forks source link

Example incorrect: matlab max maps to ops.sup #4

Open bldrvnlw opened 6 years ago

bldrvnlw commented 6 years ago

max(a) | ops.max(a) | maximum element in a

=>

max(a) | ops.sup(a) | maximum element in a

And min maps to ops.inf.

Are they abbreviations for superior inferior?

It seems that max and min in ops are actually componentwise operations over two arrays.

calee88 commented 2 years ago

This should be fixed as bldrvnlw said.

rreusser commented 2 years ago

Thanks for pointing this out! I'd gladly merge a PR to fix this, but I haven't contributed to scijs for a few years now.

(FWIW I've more recently dabbled in contributing to stdlib-js since it seems, IMO, closer to what the js numerical ecosystem needs, though it still needs a lot of work since it's much larger and more rigorous in scope.)