search

scikit-adaptation / skada

Domain adaptation toolbox compatible with scikit-learn and pytorch
https://scikit-adaptation.github.io/
BSD 3-Clause "New" or "Revised" License
60 stars 16 forks source link

Convert `BaseSelector` to the metadata router #104

Closed kachayev closed 7 months ago

kachayev commented 7 months ago

This is mostly technical detail to stay consistent with how sklearn's metadata routing is designed: BaseSelector object is a meta-estimator thus the routing should return MetadataRouter object with mapping between methods.

Closes #14

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.61%. Comparing base (740be6b) to head (bd49278).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #104 +/- ## ========================================== - Coverage 89.65% 89.61% -0.04% ========================================== Files 41 41 Lines 2860 2850 -10 ========================================== - Hits 2564 2554 -10 Misses 296 296 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.