search

scikit-adaptation / skada

Domain adaptation toolbox compatible with scikit-learn and pytorch
https://scikit-adaptation.github.io/
BSD 3-Clause "New" or "Revised" License
60 stars 16 forks source link

Remove masked inputs only if estimator does not accept `sample_domain` #123

Closed kachayev closed 7 months ago

kachayev commented 7 months ago

Per the discussion in Slack.

Selector now removes masked inputs if the base estimator does not accept sample_domain through the routing (e.g. any sklearn estimator out there). The contract is that if the estimator declares sample_domain as a parameter, it should be able to deal with inputs being partially masked (presumably targets).

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.70%. Comparing base (8726d54) to head (9afa131).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #123 +/- ## ======================================= Coverage 91.70% 91.70% ======================================= Files 43 43 Lines 3341 3341 ======================================= Hits 3064 3064 Misses 277 277 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.