Closed kachayev closed 7 months ago
Attention: Patch coverage is 95.83333%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 92.02%. Comparing base (
ba065a8
) to head (2a9774f
).
Files | Patch % | Lines |
---|---|---|
skada/tests/test_selector.py | 94.44% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is an addition to the functionality implemented in #123.
The question here is the following:
Assuming
y_train
is properly masked. NowSubspaceAlignmentAdapter
gets everything because it declaressample_domain
in the routing.LogisticRegression
gets only sources (can't work withsample_domain
)StandardScaler
???This PR makes it so
StandardScaler
gets both sources and targets, asfit
does not require labels. It previously worked this way, and it seems like this is a much stronger default. For non default behavior, we still can wrap the transformer into a proper selector when those are ready (see #116).Let me know WDYT.