search

scikit-adaptation / skada

Domain adaptation toolbox compatible with scikit-learn and pytorch
https://scikit-adaptation.github.io/
BSD 3-Clause "New" or "Revised" License
54 stars 16 forks source link

[MRG] Separate Lint and Tests + codecov configuration #135

Closed rflamary closed 4 months ago

agramfort commented 4 months ago

what if you run

pre-commit run -a

locally?

rflamary commented 4 months ago

all passed. what is happening with my pre-commit (and the one on teh action...)

agramfort commented 4 months ago

do you have precommit that runs locally when you git commit?

Message ID: @.***>

rflamary commented 4 months ago

yes i installed it with your yml file (and i see passed when i commit but it does not correct the file). Local stuff is my problem but the Lint action should fail here anyway no?

kachayev commented 4 months ago

@rflamary Your code has changes in the __init__.py file, which is excluded in ruff.toml (the very first exclude)

kachayev commented 4 months ago

I also opened an issue #136 so we don't forget to make ruff work for base modules.

kachayev commented 4 months ago

I moved the linting error to a non-excluded file, now it works as expected (linting job fails).

rflamary commented 4 months ago

thanks so much @kachayev I did not understand what was happening. I will cleanup this and merge the PR (and make the Lint test necessary for merge)