scikit-adaptation / skada

Domain adaptation toolbox compatible with scikit-learn and pytorch
https://scikit-adaptation.github.io/
BSD 3-Clause "New" or "Revised" License
54 stars 16 forks source link

[TO_REVIEW] ConditionalTransferableComponentsAdapter Implementation #137

Open YanisLalou opened 4 months ago

YanisLalou commented 4 months ago

Fixes: #96 Paper: https://proceedings.mlr.press/v48/gong16.pdf Mostly eq 7-8-9-10

YanisLalou commented 2 months ago

By guaranteeing that W is on the Grassmann manifold we loose performance in the Subspace method example on subspace shift dataset as illustrated here:

With constraint:

image

Without constraint:

image

In the bench here are the results for constrained/unconstrained CTC:

image

Is it expected or is there an issue ?