search

scikit-adaptation / skada

Domain adaptation toolbox compatible with scikit-learn and pytorch
https://scikit-adaptation.github.io/
BSD 3-Clause "New" or "Revised" License
60 stars 16 forks source link

Better coverage for linting #148

Closed kachayev closed 5 months ago

kachayev commented 6 months ago

Make sure that ruff's linter covers the following files:

I left 2 rules excluded for skada/base.py (D101 and D102), it will take quite some work for fix all the documentation.

@tgnassou There's a question for you. In skada/deep/base.py I tried to wrote proper documentation for the forward function (see files changed). There's a single "???" in there, as I'm not really sure how to explain all 3 branches in the code. Would you please help me with that?

Closes #136.

kachayev commented 5 months ago

I'm closing this one as it this point it seems like merging with main is more problematic than doing from scratch. I will open another PR.