CircularValidation doesnt work with an estimator using SelectTarget

scikit-adaptation / skada

Domain adaptation toolbox compatible with scikit-learn and pytorch

https://scikit-adaptation.github.io/

BSD 3-Clause "New" or "Revised" License

60 stars 16 forks source link

CircularValidation doesnt work with an estimator using SelectTarget #152

Open YanisLalou opened 6 months ago

YanisLalou commented 6 months ago

By using SelectTarget, the estimator only sees the target samples/labels/domains. However to compute the CircularValidation we need to train the estimator on the source THEN the target samples. Thus ValueError: Found array with 0 sample(s) (shape=(0, 2)) while a minimum of 1 is required. appears during the scoring of the method.

Solution: Return the default scorer instead ?