Closed YanisLalou closed 3 months ago
Merging #156 (1123aba) into main (0078065) will decrease coverage by
0.36%
. The diff coverage is100.00%
.
Changing somewhere make_shifted_datasets(n_samples_source, n_samples_target, ...)
with n_samples_source != n_samples_target
in the contest.py
should be enough no?
Changing somewhere
make_shifted_datasets(n_samples_source, n_samples_target, ...)
withn_samples_source != n_samples_target
in thecontest.py
should be enough no?
It was already the case i.e n_samples_source=20, n_samples_target=21
. Also in that case I can't test when X_source.shape[0] < X_target.shape[0]
AND X_source.shape[0] > X_target.shape[0]
If you want to etst different sizes you shoulh parametrize the datasets instead of doing multiple tests. This is indeed an imprtant test when the two sizes are different and larger/smaller.
An it is strange that n_samples_source != n_samples_target
but the tests pass???
The test take 26 minutes! tu run now, please choose smaller (much smaller) number of smapels to accelerate this and come back to 1-2 minuts.
The R matrix is supposed to have a shape of (m, c) with m the len of X_source and c the len of unique y_source. Otherwise we would have ValueErrors line 774 and 1274:
R[:, i] = (y_source == c).int()
whenX_target.shape[0] != len(y_source)