search

scikit-adaptation / skada

Domain adaptation toolbox compatible with scikit-learn and pytorch
https://scikit-adaptation.github.io/
BSD 3-Clause "New" or "Revised" License
52 stars 16 forks source link

[MRG] MMDLS handle case where we have X_source and no y_source #200

Closed YanisLalou closed 1 month ago

YanisLalou commented 1 month ago

Before when using the DeepValidation scorer we had this error:

  File "/Users/yanislalou/Documents/CMAP/skada_test_venv/lib/python3.9/site-packages/sklearn/metrics/_scorer.py", line 141, in __call__
    score = scorer(estimator, *args, **routed_params.get(name).score)
  File "/Users/yanislalou/Documents/CMAP/skada_test_venv/lib/python3.9/site-packages/skada/metrics.py", line 43, in __call__
    return self._score(estimator, X, y, sample_domain=sample_domain, **params)
  File "/Users/yanislalou/Documents/CMAP/skada_test_venv/lib/python3.9/site-packages/skada/metrics.py", line 433, in _score
    y_pred = estimator.predict_proba(
  File "/Users/yanislalou/Documents/CMAP/skada_test_venv/lib/python3.9/site-packages/sklearn/pipeline.py", line 728, in predict_proba
    Xt = transform.transform(Xt, **routed_params[name].transform)
  File "/Users/yanislalou/Documents/CMAP/skada_test_venv/lib/python3.9/site-packages/skada/base.py", line 288, in transform
    return self._route_to_estimator('transform', X, **params)
  File "/Users/yanislalou/Documents/CMAP/skada_test_venv/lib/python3.9/site-packages/skada/base.py", line 425, in _route_to_estimator
    output = method(X, **routed_params) if y is None else method(
  File "/Users/yanislalou/Documents/CMAP/skada_test_venv/lib/python3.9/site-packages/skada/_mapping.py", line 896, in transform
    y_source = y[source_idx]
TypeError: 'NoneType' object is not subscriptable