scikit-adaptation / skada

Domain adaptation toolbox compatible with scikit-learn and pytorch
https://scikit-adaptation.github.io/
BSD 3-Clause "New" or "Revised" License
60 stars 16 forks source link

[MRG] Make sure all API methods accept sample_domain as None #53

Closed YanisLalou closed 8 months ago

YanisLalou commented 8 months ago

Issue #17

codecov[bot] commented 8 months ago

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (895f862) 84.43% compared to head (8f3d286) 86.16%.

:exclamation: Current head 8f3d286 differs from pull request most recent head 2f428a8. Consider uploading reports for the commit 2f428a8 to get more accurate results

Files Patch % Lines
skada/utils.py 83.07% 11 Missing :warning:
skada/metrics.py 75.00% 3 Missing :warning:
skada/_utils.py 94.73% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #53 +/- ## ========================================== + Coverage 84.43% 86.16% +1.72% ========================================== Files 35 37 +2 Lines 2191 2334 +143 ========================================== + Hits 1850 2011 +161 + Misses 341 323 -18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kachayev commented 8 months ago

@YanisLalou I can't seem to push the update from my local branch here (not sure why, github previously allowed me to do so). Would you please check flake8 locally and fix all of its complaints?

YanisLalou commented 8 months ago

⬆️ Issue #58