search

scikit-adaptation / skada

Domain adaptation toolbox compatible with scikit-learn and pytorch
https://scikit-adaptation.github.io/
BSD 3-Clause "New" or "Revised" License
56 stars 16 forks source link

[MRG] Regression label for 2d classification data generation #69

Closed BuenoRuben closed 5 months ago

BuenoRuben commented 5 months ago

In this branch, I added the 'regression' label to both _generate_data_2d_classif and _generate_data_2d_classif_subspace in skada/datasets/_sample_generator.py, added a new example for this label: examples/datasets/plot_shifted_dataset_regression.py and added a new test: test_make_shifted_datasets_regressionin skada\datasets\tests\test_samples_generator.py

tgnassou commented 5 months ago

Your tests are not passing

codecov[bot] commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5fe1df9) 86.82% compared to head (37aa429) 87.16%. Report is 1 commits behind head on main.

Files Patch % Lines
skada/datasets/_samples_generator.py 95.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #69 +/- ## ========================================== + Coverage 86.82% 87.16% +0.34% ========================================== Files 38 38 Lines 2398 2439 +41 ========================================== + Hits 2082 2126 +44 + Misses 316 313 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.