search

scikit-adaptation / skada

Domain adaptation toolbox compatible with scikit-learn and pytorch
https://scikit-adaptation.github.io/
BSD 3-Clause "New" or "Revised" License
56 stars 16 forks source link

[to_review] implementation of DASVM #75

Closed BuenoRuben closed 5 months ago

BuenoRuben commented 5 months ago

I am still ensure about how to implement the class for dasvm

BuenoRuben commented 5 months ago

for now, I am just trying to create something that can be used in da_pipelines

rflamary commented 5 months ago

You shoudl call teh class DASVMEstimatorthis is not an adapter.

BuenoRuben commented 5 months ago

oh, yes, I am correcting this right now

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 99.23664% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.42%. Comparing base (d69c556) to head (71328b5).

Files Patch % Lines
skada/_self_labeling.py 99.09% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #75 +/- ## ========================================== + Coverage 90.03% 90.42% +0.38% ========================================== Files 41 43 +2 Lines 2981 3112 +131 ========================================== + Hits 2684 2814 +130 - Misses 297 298 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.