search

scikit-adaptation / skada

Domain adaptation toolbox compatible with scikit-learn and pytorch
https://scikit-adaptation.github.io/
BSD 3-Clause "New" or "Revised" License
56 stars 16 forks source link

Remove target labels in the method comparison example #92

Closed antoinedemathelin closed 5 months ago

antoinedemathelin commented 5 months ago

Hi everyone, I open this PR to fix a little bug in the plot_method_comparison.py example. Target labels were given to the fit methods, they are now removed (cf. #83).

The reweighting method are still not working, but it should be resolved soon, with PR #90

rflamary commented 5 months ago

Hello @antoinedemathelin yes this is inetresting. I think we need to modify the calls to the make_shifted_dataset function to return a DomainAwareDataset insteda of recereating one from X,y, sampledomain

kachayev commented 5 months ago

Quick suggestion to what @rflamary said: passing return_dataset=True argument to make_shifted_dataset will give you dataset right away.

antoinedemathelin commented 5 months ago

Ok, it now uses the return_dataset=True argument, then the dataset API

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b834a66) 88.54% compared to head (c8e5587) 88.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #92 +/- ## ========================================== - Coverage 88.54% 88.50% -0.04% ========================================== Files 41 41 Lines 2601 2601 ========================================== - Hits 2303 2302 -1 - Misses 298 299 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.