search

scikit-beam / autocorr

a library that endeavors to grow into a one-stop shop for all things XPCS
https://scikit-beam.github.io/autocorr/
Other
1 stars 6 forks source link

[WIP] Add CuPy backend #10

Closed leofang closed 4 years ago

leofang commented 5 years ago

This PR is an experimental work demonstrating how easy a NumPy code can be ported to CuPy that runs on NVIDIA GPUs. This is still a WIP as fftautocorr is awfully slow; multitau seems OK. If there is interest I can work on polishing and optimizing the code, adding CuPy to setup.py as an optional dependency, etc.

danielballan commented 4 years ago

Oh, nice! I just noticed this PR. This seems interesting to me! I did the same for a dask-based version that I need to open a PR for.

Would be great if you could keep pressing on this when you have time.

leofang commented 4 years ago

Looks like we won't need this PR once #15 is resolved. Closing this for now...

leofang commented 4 years ago

Looks like we won't need this PR once #15 is resolved. Closing this for now...

Note to myself: I am not saying the current NumPy-based implementation is also performant with CuPy. I am not sure what's the typical data size to be processed, so if this is a concern, we'll still need a specialized GPU version.

leofang commented 4 years ago

Superseded by #17.