scikit-beam / autocorr

a library that endeavors to grow into a one-stop shop for all things XPCS
https://scikit-beam.github.io/autocorr/
Other
1 stars 6 forks source link

FFTW should be a dependency #16

Open leofang opened 4 years ago

leofang commented 4 years ago

I think after #7 for pip install to work we need the presence of FFTW. We'll need a mechanism to detect FFTW headers at build time (similar to how pybind11 is handled). For conda recipe it's easy (just set fftw to be a build dependency), but I'm not sure how to cleanly resolve this for PyPI packaging...

tacaswell commented 4 years ago

There is a setup_requires field that mostly works. You can also go down the pyproject.toml / flit route.

leofang commented 4 years ago

If FFTW is not found, pip install from PyPI should just fail (as it does now), right?