scikit-bio / scikit-bio

scikit-bio: a community-driven Python library for bioinformatics, providing versatile data structures, algorithms and educational resources.
https://scikit.bio
BSD 3-Clause "New" or "Revised" License
882 stars 268 forks source link

improvements to neighbor joining #431

Open gregcaporaso opened 10 years ago

gregcaporaso commented 10 years ago

@ElBrogrammer and I discussed this while working on #420.

Anything else @ElBrogrammer?

Depends on:

jairideout commented 10 years ago

Maybe _compute_q? Though I'm not sure how generalizable/useful that'd be as a DistanceMatrix method.

jairideout commented 10 years ago

Would be great to add a DistanceMatrix.nj method (the actual implementation could stay where it's at).

wasade commented 10 years ago

TreeNode instantiation isn't that bad for large trees, and if the primary use case is to get a tree back, then I think it would be good to construct the tree on the fly and let the developer/user use TreeNode.to_newick if they need a str representation.

Agree re: changing OTU to node also because this isn't specific to OTUs