scikit-build / ninja-python-distributions

This project provides the infrastructure to build Ninja Python wheels.
Apache License 2.0
57 stars 15 forks source link

`pip check` fails on amd64 linux and macOS #256

Open drewbrew opened 1 month ago

drewbrew commented 1 month ago

👋🏼 Hi, it looks like pip 24.2 causes ninja to register as incompatible with my local OS due to something in the package's metadata tags.

Environments tested (all amd64):

Steps to replicate:

  1. Create a new virtualenv (python3.12 -m venv .venv)
  2. pip install --upgrade pip
  3. pip install ninja
  4. pip check

Expected behavior:

Actual behavior:

yifanmai commented 1 month ago

I'm running into this error as well on GitHub Actions with Ubuntu 22.04.4 LTS, Python 3.8.18 or 3.10.14, and pip 24.2.

I'm able to work around this error by downgrading pip to 24.1.2.

drewbrew commented 1 month ago

A coworker confirmed that macOS on ARM is also affected, and downgrading pip to 24.1.2 does indeed work around it.

filbranden commented 1 month ago

See pypa/pip#12884 for the root of the issue.

The current wheel for ninja 1.11.1.1 includes a blank line in the WHEEL file which makes the pip check break.

Can we get a new release of ninja that fixes the contents of WHEEL metadata to get this fixed? Thanks!