search

scikit-build / scikit-build-core

A next generation Python CMake adaptor and Python API for plugins
https://scikit-build-core.readthedocs.io
Apache License 2.0
240 stars 48 forks source link

Manual excludes with manual includes #858

Open henryiii opened 2 months ago

henryiii commented 2 months ago

I think manual excludes should likely override manual includes? That is, sdist.include = “*” can’t be overridden and includes everything. I think it should only override gitignores and maybe the global ignore list, but not the sdist.exclude list. We should see how it’s being used first.

Supporting an “all” source option also might help if people want to avoid gitignores.

LecrisUT commented 2 months ago

It is tricky because you can have the opposite as well. There was an idea on PEP639 about allowing gitignore style syntax, specifically the ! operator.