search

scikit-build / scikit-build-sample-projects

Sample projects demonstrating use of scikit-build
74 stars 27 forks source link

ci: add testing, fix issues #12

Closed henryiii closed 3 years ago

henryiii commented 3 years ago

Swapping the custom code for testing to nox. We could easily parametrize later, such as over Python versions.

Adding the missing pyproject.toml's to the rest of the projects. There seems to be some misbehaving with caching on scikit-build's part, hopefully won't affect CI, just reruns locally. That's why I don't build wheels yet, as it forces the cache rebuild failure due to building twice immediately (and ideally, you would just install from the wheel instead of rebuilding again). Patched the caching issues, though a proper fix should come from scikit-build eventually.

Currently cpp/cython fail, I think because they are not src based, so Python loads the local hello folder instead of the built one (I think). Edit: Yes, this is why. Moved the test file and worked around it for now.

Fixed a bunch of bugs in the tests, like missing \n's and an extra ).

Closes #2.

henryiii commented 3 years ago

PS: Hoping to apply this to #8 after it's ready and merged.

henryiii commented 3 years ago

Comments for later PRs (not for now):

henryiii commented 3 years ago

@jcfr or @thewtex (when you get out of the mountains :) ) , can I get a second set of eyes?

thewtex commented 3 years ago

I'm not sure what the other two non-hello projects are supposed to do, so I just replicated the existing testing exactly there (sdist/wheel for pen2-cython, nothing for tower-of-babel).

I think these help demonstrate generating a command line executable based on cython and a non-trivial package that is cython + python. We may want to re-name them to identify them as such.