search

scikit-build / scikit-ci-addons

Command line tool and a set of scripts useful to help drive CI
http://scikit-ci-addons.readthedocs.org/
Apache License 2.0
5 stars 9 forks source link

Cast major and minor version to int #65

Closed fbudin69500 closed 6 years ago

fbudin69500 commented 6 years ago

When major and minor are not casted to int, the comparison of CMake version 3.10.1 will detect that 10 is less than 6 and therefore download CMake win32-86 for versions where the first digit of major is less than 6 instead of comparing the whole number. The comparison would work again for values greater than 60, and break again above 100 without casting.

jcfr commented 6 years ago

Thanks 👍 Will merge after the CI complete

codecov-io commented 6 years ago

Codecov Report

Merging #65 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files           2        2           
  Lines         115      115           
  Branches       21       21           
=======================================
  Hits          110      110           
  Misses          4        4           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7066186...b1b1245. Read the comment docs.